search

d3sd1 / OnLoL-Riot-API

Riot api base for PHP. Updated constantly and almost without bugs!
2 stars 2 forks source link

Application hangs when searching summoner by name #15

Open SeaRoth opened 7 years ago

SeaRoth commented 7 years ago

Description:

Steps to reproduce:

  1. Download a fresh copy of OnLol-Riot-API
  2. Enter your API key
  3. Change the API call in index.php to $api->summonerByName("dyrus", "na");
  4. Wait

Result:

  1. Applications hangs for a long period of time and a result never comes

Expected Result:

  1. Return information regarding Dyrus

Other notes:

  1. Making other API calls work (the default ones in the index.php) Error on PC: image Error on MAC: snip20170506_1
SeaRoth commented 7 years ago

I have reproduced the issue on my MAC using a fresh copy of OnLol-Riot-API-master

SeaRoth commented 7 years ago

image

The API call being made: https://NA1.api.pvp.net/api/lol/NA1/v3/summoners/by-name/dyrus?api_key=xxx

should read: https://na1.api.riotgames.com/lol/summoner/v3/summoners/by-name/dyrus?api_key=xxx

d3sd1 commented 7 years ago

Yeah that's all because I pulled another copy of the source. Check now if pos downloading new code.

SeaRoth commented 7 years ago

I have taken it upon myself to fix the code.

I have gotten it to work - I just need to update all the other functions.

Here is a picture of how I got the summonerByName to work:

image

image

image