d3sd1 / OnLoL-Riot-API

Riot api base for PHP. Updated constantly and almost without bugs!
2 stars 2 forks source link

Default Region #7

Closed SeaRoth closed 7 years ago

SeaRoth commented 7 years ago

The update works flawlessly.
I really like the log files! I can now see which API calls I'm making because Riot's API Dashboard is lacking in options.

Only thing I would change is (if appropriate):

image Because I was calling EUW (not sure if this even matters) image

I tried making changes to riot.php so I could contribute but I failed.

Things I tried:

image image but I'm a boosted bonobo and it didn't work obviously (haha).

d3sd1 commented 7 years ago

You should set up default region on config.conf, try it and if it persists I'll take a look :P

d3sd1 commented 7 years ago

Oh lol understood so bad. Im changing it, but it doesn't matters, since static data it's the same on all regions ;P

PD: Working on a really heavy update, it will have a new feature that you will really like it, it will be V2, and should be avaliable tomorrow or less than a week.

SeaRoth commented 7 years ago

I set up the default region in config.conf since the beginning. :)

image

1st Test:

-Function parameter $region to 'euw' image

and euw shows up in the log files: image

2nd Test:

-Function parameter $region to 'na' image

and na shows up in the log files: image

Notes:

d3sd1 commented 7 years ago

Yeye, just worked on solve it, like this: image image As a spoiler, right now I'm working on stats. Feel free to tell me some stats that you would like to have. Per example, summoners per region (%) and number.

SeaRoth commented 7 years ago

Is this what you're talking about? (Summoners per region (%) and number:

image

d3sd1 commented 7 years ago

That's a ladder, but I will add too :)

d3sd1 commented 7 years ago

Will add on next patch! =)