d3sd1 / OnLoL-Riot-API

Riot api base for PHP. Updated constantly and almost without bugs!
2 stars 2 forks source link

Unknown Region and API calls #8

Closed SeaRoth closed 7 years ago

SeaRoth commented 7 years ago

Description:

Steps to Reproduce:

  1. Use an undefined variable or " na " (with spaces) as the region when calling a function (e.g. summonerByName) with OnLoL-Riot-API
  2. Look at the log files

Results:

  1. Lots of API calls to unknown endpoints (see images below)

Expected Results:

  1. Return an error
  2. Don't do anything

Notes:

Images:

image

image

d3sd1 commented 7 years ago

It retrieves NaN, so I assume that you deleted "na" on riot.api.regions, since it's an array which needs the regions where your api works. Can you give me the request you're making and config.conf (without api key and mysql con)?

d3sd1 commented 7 years ago

Solved on next patch, I just realised I made something with it lol. Repost this on trying next patch, it will be avaliable today almost for sure.

d3sd1 commented 7 years ago

Added a subversion 1.4, with too many new features and some stats coded. Would like to add you on skype (if you like) to talk something about this patches, and give an instant feedback. Check it out asap! :P

d3sd1 commented 7 years ago

My skype is andiganja btw

SeaRoth commented 7 years ago

added