d3vilh / openvpn-ui

Web User Interface for OpenVPN
MIT License
169 stars 39 forks source link

Credits to authors #43

Closed bugsyb closed 7 months ago

bugsyb commented 7 months ago

It would be really nice if initial authors of the code which is claimed here as yours, would be referenced. For example: https://github.com/bugsyb/openvpn-web-ui-docker-build Which is effectively: https://github.com/d3vilh/openvpn-ui/tree/main/build

And situations like maintainer entry replaced with your credentials with zero credit for others work. It is not only about my work, there's certainly many others who did a lot skipped and code is claimed as yours.

Just claiming others work as yours is no nice.

At the same time, all integrations put all together into one place is really good - thumbs up for that.

d3vilh commented 7 months ago

Hey @bugsyb, I appreciate your input. Thanks for pointing this out, and all the contributions you did as well. Our codebase is indeed based on Adam's master repository (https://github.com/adamwalach/openvpn-web-ui/tree/master/build) and honestly I was inspired by your building scripts at the very beginning. To ensure proper acknowledgment this inspiration now part of the OpenVPN-UI build code.

It's important to recognize everyone's contributions. Would you mind doing the same in your repository by adding Adam as a coauthor?

Thanks a lot!

bugsyb commented 7 months ago

Good point, readme.md has been awaiting for an update for quite some time and it has been pushed out now (https://github.com/bugsyb/openvpn-web-ui-docker-build/blob/main/README.md).

Good work integrating so many elements on top of what @adamwalach did, as it certainly took a lot of time and effort. Thanks for the work.

permanutry commented 6 months ago

Hey guys you both are awesome. Nice tread btw. I also would like to be in credits somewhere, how can I participate 😁😎

Im kidding 😁 Merry Christmas to you allπŸŽ„πŸŽ„πŸŽ„