Eslint indent - Githubissues

d3x0r / JSON6

JSON for Humans (ES6)

Other

237 stars 15 forks source link

Eslint indent #27

Closed brettz9 closed 4 years ago

brettz9 commented 4 years ago

Builds on #26 .

This adds some consistency with indents (and semi-colons). Let me know if you prefer 2 spaces or tab.

It also caught a few bugs such as a capitalized FALSE and a few misspelled vars.

Fix: A few misspelled variables
Optimization: Add and enforce use strict
Linting: Add eslint with recommended and ignore file
Linting: Enforce 4 spaces indent
Linting: Enforce consistent semicolons

brettz9 commented 4 years ago

I've merged back the more recent merges and additions. Thanks for the merges!

Btw, you might want to wait on too much digging into the code until after reviewing #28 as I got to around 97% coverage (though maybe you'll want #28 broken up which I can of course do).

brettz9 commented 4 years ago

I've merged your changes here. Please, please, if you are planning to review this PR, do so before making any other changes, as the high number of (albeit trivial) changes, makes for troublesome merging. Thanks!

brettz9 commented 4 years ago

Closing in favor of tacking on the desired switch to tabs at the back end of #29.