d3x0r / JSON6

JSON for Humans (ES6)
Other
236 stars 14 forks source link

Linting pkg json #36

Closed brettz9 closed 4 years ago

brettz9 commented 4 years ago

Ok, one more batch of build/maintenance changes. The significant one is the husky/lint-staged addition to try to ensure that no linting regressions can even be committed, and that there are no test regressions on push. I added some "lite" npm scripts which avoid the benchmarking tests (to avoid running benchmarking on push).

If you are not comfortable with the eslint auto-fixes, I can change so that it just warns us (before commit) to fix it ourselves. But with the eslint rules you have enabled (and without third party eslint plugins, etc.), I think the fixes should be pretty safe and conveniently address accidental tab or indent issues.

brettz9 commented 4 years ago

Also, per https://lgtm.com/projects/g/d3x0r/JSON6/?mode=list , throwEndError is passing arguments that don't exist in the function definition (actually it is commented out). Would you like me to remove those extra arguments, use the currently unused variable in some way, or enable it to avoid the linting errors, and instead disable linting errors for no unused variables (i.e., if I enable the currently commented out c argument, the linters will start complaining about this variable being unused unless I suppress that particular error).