Downgrade node-resolve - Githubissues

d3x0r / JSON6

JSON for Humans (ES6)

Other

237 stars 15 forks source link

Downgrade node-resolve #41

Closed brettz9 closed 4 years ago

brettz9 commented 4 years ago

Downgrade node-resolve due to https://github.com/rollup/plugins/issues/412 .

The Node 10+ versions are also having problems for some reason on https://travis-ci.org/github/d3x0r/JSON6 builds but not on my https://travis-ci.org/github/brettz9/JSON6 builds. In any case, downgrading the node-resolve plugin will hopefully work for the Node 10+ versions until such time as that issue may be addressed.

(I can close this PR if it doesn't pass with Node 10+.)

brettz9 commented 4 years ago

Yeah, the downgrading fixed that issue, so I think this PR should be merged. There's still the issue of Node < 10, but as you can see from https://travis-ci.org/github/d3x0r/JSON6/builds/692042146 , the Node 10+ builds are now passing (on your Travis as well as on mine). I've just added a commit now to check Node 14 though as well, so we'll see if that passes too.