search

d4f / backbone-highway

Routing Backbone with style \o/
MIT License
19 stars 5 forks source link

Unit tests? #32

Open bpatram opened 7 years ago

bpatram commented 7 years ago

There seems to be no unit tests for this project. Is there any intention to add unit tests? I am looking to use this route implementation for a production project but I am worried about possible regressions in the future. It would also be helpful for those looking to contribute to it (like myself).

ghost commented 7 years ago

Hi @bpatram !

The v1 had unit tests but I haven't had time to re-implement them for the v2 rewrite. Help would be more than welcome.

I have implemented this router in big production sites with no trouble. So I do want to keep a working API and to prevent regressions for future evolutions. :)

Again, any help on what direction this library should take in the future is very welcome.

Cheers

ghost commented 7 years ago

@bpatram I forgot that I had already started a branch for unit tests. There is not much being tested so far but the test environment is already setup using karma and mocha. I created a PR showing what is already done: #33

ghost commented 7 years ago

More being done in PR #41