search

d4lfteam / d4lf

Diablo 4 Loot Filter
MIT License
167 stars 41 forks source link

Socketed Gems create false negative (on pants) #190

Open dominicnunez opened 8 months ago

dominicnunez commented 8 months ago

From the images you can see that if I socket gems into the pants, the filter indicates these pants are not good but fine with no socketed gems. Not a big deal but kind of annoying. I haven't seen this happen with anything but pants.

image image

chrisoro commented 8 months ago

How does your general.Armor filter look like?

dominicnunez commented 8 months ago

image

aeon0 commented 8 months ago

Its a known issue. What happens is that the socket is not detected and d4lf reads the affix as "damage reduction from close enemies from close enemies maximum life maximum life". It probably then matched the affix against maximum life instead of damage reduction and since you already have maximum life as an affix on the item its ignored.

I am not planning to work around this for now. The focus of the lootfilter is filter new loot. If you already put gems into an item I assume you want the item and know the item.

I will keep the issue open, because I do understand that its a bit annoying to see the red color on an actually really good item you have.

epicwalrus10 commented 6 months ago

Hi! I'm wondering what the discord link is for the loot filter discord. I'm having a hard time with the loot filter. Or if anyone has any examples or even a template of what their .yaml file is like.

chrisoro commented 6 months ago

it's linked in the readme. readme also tells you how to configure it. :)

https://discord.gg/YyzaPhAN6T