d4nj1 / TLPUI

A GTK user interface for TLP written in Python
GNU General Public License v2.0
1.11k stars 83 forks source link

Generic icon shown on GNOME (wayland) overview and dash #149

Closed badshah400 closed 5 days ago

badshah400 commented 5 months ago

TLP UI shows a generic icon for open application instances on the GNOME overview (wayland) and dash (see screenshot) because it sets an app ID that is different from the name of the .desktop file.

Fix is straightforward:

diff --git a/tlpui/__main__.py b/tlpui/__main__.py
index a328604..d926d77 100755
--- a/tlpui/__main__.py
+++ b/tlpui/__main__.py
@@ -18,7 +18,7 @@ Gtk.StyleContext.add_provider_for_screen(
 )

 # Set window properties
-GLib.set_prgname('tlp-ui')
+GLib.set_prgname('tlpui')
 Gdk.set_program_class('Tlp-UI')

 # Apply custom scalable icons to icon theme

Many thanks for the great app!

tlpui

Integral-Tech commented 5 months ago

I am using KDE Plasma on Wayland. The same issue as yours.

badshah400 commented 5 months ago

So... you just took my, admittedly straightforward, patch and simply put your name on the commit? Anyway, as long as it gets merged, fine by me, I guess.

Integral-Tech commented 5 months ago

So... you just took my, admittedly straightforward, patch and simply put your name on the commit? Anyway, as long as it gets merged, fine by me, I guess.

I am sorry I forgot to put your name on the commit. I have just changed the commit author to you.

badshah400 commented 5 months ago

Thanks a bunch and please accept my apologies for previous salty message.

d4nj1 commented 5 days ago

This is merged in will be in the next release. Thanks for your contribution.