search

d4nyll / smartscroll

jQuery plugin for scrolljacking and auto-hashing
https://d4nyll.github.io/smartscroll/
MIT License
257 stars 45 forks source link

scroll method has hardcoded speed #50

Closed havlasme closed 5 years ago

havlasme commented 5 years ago

I've noticed that there is hardcoded animation speed in scroll method

https://github.com/d4nyll/smartscroll/blob/749a7e74f12e12452ba7a9e0445fddf7c747a8af/smartscroll.js#L277

https://github.com/d4nyll/smartscroll/blob/749a7e74f12e12452ba7a9e0445fddf7c747a8af/smartscroll.js#L279

I believe it should use options.animationSpeed instead of specifying value 700.

d4nyll commented 5 years ago

You're right @tomashavlas! Thanks for the spot. Fixed it with a commit just now!