d4rkc0d3r / d4rkAvatarOptimizer

d4rkpl4y3r's VRChat Avatar 3.0 optimizer
MIT License
402 stars 17 forks source link

Shader doesn't fallback nicely - albedo texture isn't shown when custom shaders are disabled in-game #17

Closed Asovrix closed 11 months ago

Asovrix commented 2 years ago

As in topic. Issue only appears on meshes which end up having part toggles added by this shader, even though original one (ACLS in this case) should fall back more nicely. Unity_2022-11-22_04-51-26 VRChat_2022-10-22_22-30-37 039_1920x1080

d4rkc0d3r commented 2 years ago

It should only happen if the _MainTex is not already an atlas and gets put into a Texture2DArray. Can you check if it really is just from merged toggles? (Also merged shader toggles fall back to show everything as on when shaders a blocked, another limitation)

Asovrix commented 2 years ago

Yeah, I am aware of everything defaulting to be shown with only shaders being hidden. MainTex on body parts that are solid white on above photo are all indeed using 2DArray textures, it doesn't seem to be related to toggles, especially only now I realized that my shoes are fine even though they are toggleable.

d4rkc0d3r commented 2 years ago

Hmm maybe I should write those limitations down in the README. I could even add an info box that only shows up when it merges different _MainTex textures into an array.

d4rkc0d3r commented 11 months ago

3.3.0 now has merging of _MainTex as a separate option that is off by default.