search

d4rken-org / capod

A companion app for AirPods on Android.
https://play.google.com/store/apps/details?id=eu.darken.capod
GNU General Public License v3.0
541 stars 49 forks source link

Support edge-to-edge rendering on Android Q+ #146

Closed Seanathan10 closed 1 year ago

Seanathan10 commented 1 year ago

Hello!

This app has been insanely helpful for using AirPods on Android. However, it was missing one small detail: edge-to-edge rendering. Since the release of gesture navigation with Android Q (10), apps can render below the navigation bar for a cleaner and more modern look. I've done this with CAPod and was hoping my changes can be merged with the main repository to provide this experience to all who find and use this app. Here's the difference with using edge-to-edge rendering:

No edge-to-edge

Edge-to-Edge
MainPageOld There is this unsightly default black box around the nav pill MainPageNew Clean!
SettingsOld The black box blocks content SettingsNew Clean! And text below it is now visible
MainPageLandscapeOld Landscape mode has the same issues MainPageLandscapeNew But also gets the same benefits
PixelXL-DarkOld The previous photos were running on a Pixel 7 (Android 13) PixelXL-DarkNew Here it is on a 2016 Pixel XL (Android 10) in dark theme, and shows 3 button nav compatbility

One of the things I haven't tackled in this pull request is rendering below the camera cutout when in landscape mode. For the purposes of streamlining, I didn't do that yet. I simply wanted to make the app look slightly cleaner.

Please let me know if you have any questions or concerns regarding my changes. I hope this can get merged!

d4rken commented 1 year ago

lgtm :+1: