d4rken-org / capod

A companion app for AirPods on Android.
https://play.google.com/store/apps/details?id=eu.darken.capod
GNU General Public License v3.0
541 stars 49 forks source link

Add PUSH_NOTIFICATIONS permission to AndroidManifest.xml for wearos #203

Closed kavishdevar closed 5 months ago

kavishdevar commented 6 months ago

Fixes https://github.com/d4rken-org/capod/issues/154 by adding the required uses-permission for push notifications tag in AndroidManifest.xml for wearos.

d4rken commented 6 months ago

Have you tested this? There is no PUSH_NOTIFICATIONS permission in Android.

kavishdevar commented 6 months ago

This permission was introduced in API Level 33 (Android 13). Refer https://developer.android.com/develop/ui/views/notifications/notification-permission

I have tested it on my Galaxy Watch 6 running WearOS 4 (Android 13)

rcky844 commented 5 months ago

This permission was introduced in API Level 33 (Android 13). Refer https://developer.android.com/develop/ui/views/notifications/notification-permission

I have tested it on my Galaxy Watch 6 running WearOS 4 (Android 13)

I think you've got the name of it wrong, the page states: android.permission.POST_NOTIFICATIONS

kavishdevar commented 5 months ago

Oh, my bad, fixed the typo now.

I actually buit a few builds locally and then forked the repository for the PR. So, I didn't actually test the code that I pushed... Apologies!