d4rken-org / permission-pilot

Android permission explorer 🧑‍✈️
GNU General Public License v3.0
404 stars 40 forks source link

Do you mind if I write a request to be added to F-Droid? #148

Open Artem13327 opened 2 years ago

d4rken commented 2 years ago

I don't mind, see also https://apt.izzysoft.de/packages/eu.darken.myperm/

d4rken commented 2 years ago
AuthorName: Matthias Urhahn
AuthorEmail: darken@darken.eu
AuthorWebSite: https://darken.eu
Donate: https://github.com/sponsors/d4rken

SourceCode: https://github.com/d4rken-org/permission-pilot
IssueTracker: https://github.com/d4rken-org/permission-pilot/issues
Changelog: https://github.com/d4rken-org/permission-pilot/releases
offa commented 1 year ago

Are there any news regarding F-Droid submission?

d4rken commented 1 year ago

Hm, basically waiting for CAPod to be approved, which is waiting on someone from F-Droid for review: https://gitlab.com/fdroid/rfp/-/issues/2222#note_1116255404

CAPod uses the same new build script that generates a VERSION file that F-Droid can parse for automatic builds: https://github.com/d4rken-org/permission-pilot/blob/main/VERSION

Once that is working, the same script could be used for all my apps to get automatic builds on f-droid.

IzzySoft commented 1 year ago

@d4rken for myperms, we have an issue concerning updates. Our update checker only parses the build.gradle using regular expressions, so variables or function calls do not work. Which means we need versionCode and versionName available literally (which they are currently not) – ideally in the place just pointed to, but if you prefer you could also have that defined when making a release by writing it e.g. to a version.txt, for example using the same syntax as Flutter does (version: <versionName>+<versionCode>). Could that be done?

d4rken commented 1 year ago

Permission Pilot uses the same release script as CAPod, and creates a VERSION file: https://github.com/d4rken-org/permission-pilot/blob/main/VERSION

Could the same solution from CAPod be used here too?

IzzySoft commented 1 year ago

Yes, sure! That's what I meant by "as Flutter does". A + or a space as separator – as long as you don't have spaces in your versionName that should not matter at all :smile: Just let us know once it's there, and where to look for it (ideally in the RFP), and we'll pick it up.

d4rken commented 1 year ago

@IzzySoft Permission Pilot already uses the same scheme as CAPod, the VERSION file is available. https://github.com/d4rken-org/permission-pilot/blob/main/VERSION

What is the blocker here? Did I forget some tweak that I did in CAPod and didn't do here? 🤔

IzzySoft commented 1 year ago

Ah, right – must have missed that. Thanks Matthias, adjusted in the RFP and marked it "ready for packaging" then.