search

d4rken-org / permission-pilot

Android permission explorer 🧑‍✈️
GNU General Public License v3.0
407 stars 42 forks source link

[New Feature]: Swipe to switch tabs #19

Closed TheRealMystic closed 2 years ago

TheRealMystic commented 2 years ago

Please allow for switching between tabs with a simple swipe.

d4rken commented 2 years ago

Will make performance on low end devices worse as both lists will stay in memory. :thinking:

TheRealMystic commented 2 years ago

Will make performance on low end devices worse as both lists will stay in memory. 🤔

Do we still have that problem in 2022? 🤔

How about a Setting to enable swipe gestures? Swipe gestures will remain disabled by default. User can enable it if he wants, but app will warn him about lags on low end devices.

d4rken commented 2 years ago

Would be very low priority, to make this swipable, I'd have to replace the Container(Fragment) with a Container(ViewPager(Fragment1,Fragment2)).

ViewPager can be quite buggy. I don't think many people swipe left/right for a use-case. It might feel nice, but it would not be used for comparing list items or something like that.

dragonGod97677 commented 2 years ago

Do we still have that problem in 2022? 🤔

Well for us (including me) users that still dont have money to buy phone least with 3Gigs of RAM, yes

How about a Setting to enable swipe gestures? Swipe gestures will remain disabled by default. User can enable it if he wants, but app will warn him about lags on low end devices.

👍

TheRealMystic commented 2 years ago

Would be very low priority, to make this swipable, I'd have to replace the Container(Fragment) with a Container(ViewPager(Fragment1,Fragment2)).

No problem.

ViewPager can be quite buggy. I don't think many people swipe left/right for a use-case. It might feel nice, but it would not be used for comparing list items or something like that.

I agree this is not too important.

But I would disagree if you say many people don't use it. Anyone who uses gestures in his phone will have a natural tendency to switch tabs using swipe gestures. But it is completely fine to keep this is in low priority for the time being.