d4rken-org / reddit-android-appstore

https://www.reddit.com/r/Android/comments/50rafp/meta_we_have_an_app_wiki_with_over_700_apps_made/
Apache License 2.0
365 stars 56 forks source link

Release v0.8.0 #149

Closed d4rken closed 7 years ago

d4rken commented 7 years ago
bobheadxi commented 7 years ago

Ah... i messed up the merging @_@

damn i messed it up real bad

S.O.S. @d4rken

d4rken commented 7 years ago

What happened?

bobheadxi commented 7 years ago

Rebase merge made master deviate a lot from dev, says there is a ~20 commit difference now

d4rken commented 7 years ago

No worries.

Check here for rebase vs merge.

Merging from dev into master is preferably done through a merge commit, not a rebase. Reserve rebase to update your own feature branches.

To fix this there are two options:

You already began the later option which is fine, though I think you also rebased them instead of merging them into master. Check the github button before pressing it 😉.

I'm now just merging (merge commit, not rebasing!) the dev branch into the master , I'll tag the final commit, build the apk and everything is in order.

To continue on dev with the next update I'll then pull the changes to master back into dev to get them to the same state.

d4rken commented 7 years ago

👍

bobheadxi commented 7 years ago

Ah, my bad - I think I did rebase the revert 😢 thanks! Unfortunately looks like it really threw off the contributor stats as well

Also, given this is a fairly sizeable update any chance we might get a shoutout on the sub again for some installs? 🙋‍♂️