search

d4rken-org / reddit-android-appstore

https://www.reddit.com/r/Android/comments/50rafp/meta_we_have_an_app_wiki_with_over_700_apps_made/
Apache License 2.0
367 stars 56 forks source link

proper pull request #168

Closed TacoTheDank closed 6 years ago

TacoTheDank commented 6 years ago

pretty much the same as before but a lot better code review because done in android studio

also properly updated gradles and gradlews by using ./gradlew wrapper --gradle-version 4.9 --distribution-type all

android studio cleans and builds successfully

heres apks built from this https://app.box.com/v/redditandroidappstore

d4rken commented 6 years ago

Thank you for the PR, I appreciate your effort, but: Don't make huge sweeping changes in one PR.

You've touched 114 files with this PR. Split them up by logical changes.

Instead of "I've made everything better", create PRs that fix specific issues so they can be reviewed accordingly.

TacoTheDank commented 6 years ago

i must look so desperate lmao, god i suck

welp time to fix it xd

d4rken commented 6 years ago

i must look so desperate lmao, god i suck

Not at all, I admire your efforts.

welp time to fix it xd

Just go with small PRs.