d4rken-org / sdmaid-se

SD Maid 2/SE is Android's most thorough cleaning tool.
https://play.google.com/store/apps/details?id=eu.darken.sdmse
GNU General Public License v3.0
2.57k stars 393 forks source link

Re-evaluate how the accessibility service closes the last app / SD Maid when running via scheduler #1322

Open d4rken opened 2 months ago

d4rken commented 2 months ago

As of #1320 we now use single back button presses on Android TV, and press the home button on non-TV devices. Because pressing the home button can change the last open-app, we could reevaluate using the back button. See #1240

Possible improvements:

MarkyMarkDE commented 2 months ago

Thanks for adding it. On my Pixel7 with Android 14 this push back method works same as on AndroidTV, maybe we can do in a first step AndroidTV and Pixel Devices are handled same? If we know more details which Android Version or which ROM don't work with that, we can thinking about different / more detailed rules or something.

You can also add a comment in the code, that the push back method properly work on: Pixel7 with Android 14 and Patches of July 24 AndroidTV with Android 11 and Patches April 24 on waipu.tv 4 k Stick and also on your Testsystem xx

FYI: I'm pretty sure, that something other has changed between 0.23.0 and 0.24.* what breaks something.

You have removed the push back method in 1.0.1 right? But the main problem started on 0.24.0+ at the first time ... In 0.23.0 SDMaid is a 'hidden and invisible background process' and on 0.24.* it becomes visible, but why? It's hard to explain, maybe you check 0.23.0 and also 0.24.0 to see the finish process and see what I mean.

If you need, I will check 0.23.1, 0.23.2 and 0.23.3, then I'm able to say 'something in xx cause the problem' so you have it maybe easier to find the reason for the break.