search

d4rken-org / sdmaid

SD Maid is an Android app that helps you manage files and apps.
https://play.google.com/store/apps/details?id=eu.thedarken.sdm
1.51k stars 742 forks source link

[Choose filter] function #1472

Open Edfgdz opened 6 years ago

Edfgdz commented 6 years ago

Want to add fuction named[Choose filter] This is usercase. Supposed there is a Userfilter A in SystemCleaner.When i choose new files SD Maid will creat a new filter named B and it will add files basepathes to filter B. But sometime i want to add file basepathes to Userfilter A,not creat a new filter to contain them.It means i must copy basepathes first then into Filter B to paste them. So i want to add [Choose (Existing) Filter]to directly put basepathes into Userfilter A for skipping copy and paste action. How do you consider it?

d4rken commented 6 years ago

Some thoughts:

What if the target filter has options like "DIRECTORY", but the pathes we add are files? Do we just remove the DIR/FILE restriction?

This could also be dangerous, if we remove restrictions it could match too much without the user noticing...

But the user "should" check the results after adding new pathes, so maybe we just ignore edge cases for now...

When selecting "Add to SystemCleaner" we show a dialog that contains the existing filters and a NEW button...

Edfgdz commented 6 years ago

Why it could match too much without restriction? In fact,usually i wont check the result after scan.

Edfgdz commented 6 years ago

If there is conflict between restriction and added pathes,can sd maid show a pop up to remind user of it?

d4rken commented 6 years ago

Everything is possible, the question is at which point does it get too complicated or too much work for a single feature.

Edfgdz commented 6 years ago

User may know what restrictions are in each filters. Generally,when i want to add pathes to some-filter,i know which filters have restriction because those are special filters and i will avoid them for select filters without restriction in them. @d4rken

Edfgdz commented 6 years ago

When user choose a filter,user can go into that filter editing page to add new file/folder pathes,so they can see restrictions in that filter. Can this solve the problem of restriction conflicts?

Edfgdz commented 4 years ago

I am not sure if you think this problem too complexly, normally users should know how they set the userfilters themselves, it means when adding paths to existing filters, they should know which filters have directory /file restriction and which have empty or not empty restriction etc.

So should we care about this problem?