No excluding files on save

[nielsenramon]

I am trying to exclude a file (normalize.scss) from combing on save but I can't get it to work. I tries absolute paths and relative ones but nothing seems to work.

The .csscomb.json file is in my stylesheets folder and generic/_normalize.scss is in there as well.

In my config I have the following line:

"exclude": ["generic/**"],

Any idea how to fix this?

Thanks!

[d4rkr00t]

Hi, I guess it's happening because plugin provides file content to csscomb instead of file path here https://github.com/d4rkr00t/css-comb-atom/blob/master/src/css-comb.js#L73

I'll take a look at this issue at weekends.

[nielsenramon]

@d4rkr00t Alright thanks man!

[d4rkr00t]

Should work now :)

[nielsenramon]

@d4rkr00t Hmm I can't get it to work on my client. Latest version. Even re-installed your package. Keeps executing in that folder. Anything wrong on my side? How does the package check the path?

[d4rkr00t]

Hi, it checks relative to root directory, where atom is opened.

I'll recheck it again, maybe i messed something up :)

[d4rkr00t]

@nielsenramon Oh, I see from original description that .csscomb.json is in stylesheets folder, so I have to rewrite exclude logic a bit to make it work.

[d4rkr00t]

I think you can write exclude path relative to the root folder and it should work.

"exclude": ["stylesheets/generic/**"],

And I'll fix it in few days :)

[nielsenramon]

@d4rkr00t Indeed I had to use the path relative to the root 👍 Thanks! You could indeed build it so the excluded files are relative to the .csscomb.json file location but it's already awesome I no longer have to disable the plugin just for the exluded files ⭐

[d4rkr00t]

Yep, I'll do it :)

[d4rkr00t]

Second attempt :)

@nielsenramon Can you check it please?

[nielsenramon]

@d4rkr00t Awesome it works great! Thanks for the effort man :)

[d4rkr00t]

Thanks for bug report!