d4rkr00t / language-stylus

Stylus language support for Visual Studio Code
MIT License
44 stars 11 forks source link

Missing New CSS Grid Support #62

Closed mattwaler closed 6 years ago

mattwaler commented 6 years ago

Syntax highlighting for CSS Grid spec does not highlight correctly. I have attached a screenshot to help.

screen shot 2018-03-15 at 4 40 51 pm

MartinMuzatko commented 6 years ago

I don't get why stylus can't use the default css properties and has to maintain its own list. However, this would be very much appreciated.

ErickPetru commented 6 years ago

The CSS Grid Layout Module is in Candidate Recommendation for a while now and VS Code already recognizes its properties very well. But language-stylus still show as unknow properties. Here's the list of the new properties to be added to the recognized ones:

column-gap
gap
grid
grid-area
grid-auto-columns
grid-auto-flow
grid-auto-rows
grid-column
grid-column-end
grid-column-start
grid-row
grid-row-end
grid-row-start
grid-template
grid-template-areas
grid-template-columns
grid-template-rows
row-gap
ErickPetru commented 6 years ago

Please merge pull request #66 to add the properties.

mattwaler commented 6 years ago

@ErickPetru is there any way for me to get this working in my VS code until the request gets merged?

ErickPetru commented 6 years ago

@mattwaler you can get a local copy of this reposity and update the line 414 as I did here: https://github.com/d4rkr00t/language-stylus/pull/66/files. Then, unsubscribe from the official extension and add your local copy as an extension (here's the documentation about it: https://vscode-docs.readthedocs.io/en/stable/extensions/install-extension/). The proccess is a little overwelming and for sure you stop receiving updates from the official extension, so I don't recommend.

mattwaler commented 6 years ago

@ErickPetru Gotcha, I'll just wait for the merge. Thanks for your help!

d4rkr00t commented 6 years ago

Merged: https://github.com/d4rkr00t/language-stylus/pull/66