d6lts / drupal

Fork of Drupal core for Drupal 6 LTS support.
https://www.drupal.org
GNU General Public License v2.0
130 stars 45 forks source link

One more theme.inc change #53

Closed splash112 closed 3 years ago

splash112 commented 4 years ago

Hi,

One last theme.inc change that reduced errors on my site. theme_inc.zip

NiklasBr commented 4 years ago

Can you do a pull request or just paste the diff here instead?

splash112 commented 4 years ago

Sure, hope to learn how to do a pull request soon:

diff --git a/includes/theme.inc b/includes/theme.inc index a47fa1e4aa..4683382d2a 100644 --- a/includes/theme.inc +++ b/includes/theme.inc @@ -1216,7 +1216,7 @@ function theme_links($links, $attributes = array('class' => 'links')) { global $language; $output = '';

splash112 commented 4 years ago

`diff --git a/includes/theme.inc b/includes/theme.inc index a47fa1e4aa..4683382d2a 100644 --- a/includes/theme.inc +++ b/includes/theme.inc @@ -1216,7 +1216,7 @@ function theme_links($links, $attributes = array('class' => 'links')) { global $language; $output = '';

splash112 commented 4 years ago

Hi Niklas,

Maybe it works better in a mail.

diff --git a/includes/theme.inc b/includes/theme.inc index a47fa1e4aa..4683382d2a 100644 --- a/includes/theme.inc +++ b/includes/theme.inc @@ -1216,7 +1216,7 @@ function theme_links($links, $attributes = array('class' => 'links')) { global $language; $output = '';

NiklasBr commented 4 years ago

@splash112 I created a PR for you, in the future you can do this yourself for simple changes right here on Github by editing the directly.

dsnopek commented 4 years ago

Thanks! I posted some review on the PR #54