search

d6lts / drupal

Fork of Drupal core for Drupal 6 LTS support.
https://www.drupal.org
GNU General Public License v2.0
130 stars 45 forks source link

Trying to fix https://github.com/d6lts/drupal/issues/52 : back to a s… #55

Closed ylp-ineris closed 3 years ago

ylp-ineris commented 4 years ago

…ingle table name prefix while quoting all table names with backticks (and not just table names which are keywords in MySQL 8+)

dsnopek commented 4 years ago

Thanks for the PR!

However, I don't think we want to quote all table names with backticks. Only messing with table names that were reserved keywords was a compromise that we struck when implementing the MySQL 8 changes, and I don't see a compelling reason to go back on that compromise.

ylp-ineris commented 4 years ago

Ok, a new proposal whith the last commit. It is a way to only quote MySQL 8 keywords-like table names while fixing https://github.com/d6lts/drupal/issues/52

Maybe the heavier modification this 2 steps treatment involves is a compelling reason to go back on that compromise? Maybe not :)

Note that I haven't test this version (the previous is in production on one of the website I am in charge of).

dsnopek commented 3 years ago

Sorry for taking so long to get back to this! I finally had a chance to test your PR in bunch of different cases and it works great. :-)

ylp-ineris commented 3 years ago

Cool! And I see it’s part of Drupal 6.58… I’m happy to be a contributor of Drupal 6!

De : David Snopek @.> Envoyé : jeudi 1 juillet 2021 21:55 À : d6lts/drupal @.> Cc : LE-PAPE Yannick @.>; Author @.> Objet : Re: [d6lts/drupal] Trying to fix https://github.com/d6lts/drupal/issues/52 : back to a s… (#55)

Sorry for taking so long to get back to this! I finally had a chance to test your PR in bunch of different cases and it works great. :-)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fd6lts%2Fdrupal%2Fpull%2F55%23issuecomment-872509740&data=04%7C01%7Cyannick.le-pape%40ineris.fr%7Ceeee54847c3044beeb3808d93cca185e%7C58e304085f614cea8a9f7a6eb45ff0b1%7C1%7C0%7C637607660953732534%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=Vu1J8x%2FsNczG62GXM65veZTT0J9IddCbOSO%2FhS327fQ%3D&reserved=0, or unsubscribehttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAMVXSP54Q5JJIMG2WY6AJWDTVTBYZANCNFSM4PEZM5BQ&data=04%7C01%7Cyannick.le-pape%40ineris.fr%7Ceeee54847c3044beeb3808d93cca185e%7C58e304085f614cea8a9f7a6eb45ff0b1%7C1%7C0%7C637607660953732534%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=RCiPw4GnP78GXPvuyh7RWjCDpNBBagIRfnQyJRk46kc%3D&reserved=0.