search

d6lts / drupal

Fork of Drupal core for Drupal 6 LTS support.
https://www.drupal.org
GNU General Public License v2.0
130 stars 45 forks source link

Fix fatal errors on PHP8 #60

Closed rmuit closed 3 years ago

rmuit commented 3 years ago

These fatals on PHP8 are all notices (or warnings) in PHP7.4. I've packed all the ones I found* into one PR.

Individual commit messages hold details.

The last commit is an update of the full typo3/phar-stream-wrapper library to 2.2.1. It basically has two PHP7/8 fixes in PharStreamWrapper, plus some other changes for edge cases/Windows that I don't see being a problem. Still works on PHP5.3, and the only reason for the minor version bump is a change in dependencies. (Optional upgrade of a supporting library, which I ignored.)

* except PRs #62 and #30

* Mostly by running simpletest on PHP8. If you want to publish https://github.com/rmuit/simpletest as D6LTS, feel free to.

dsnopek commented 3 years ago

Thanks! These changes all look good, and I did some testing with them on PHP 5.3 as well, to make sure this wouldn't affect folks stuck on legacy versions.