d6lts / drupal

Fork of Drupal core for Drupal 6 LTS support.
https://www.drupal.org
GNU General Public License v2.0
130 stars 45 forks source link

Fix fatal error in error handler on PHP8. #62

Closed rmuit closed 3 years ago

rmuit commented 3 years ago

This is separate from PR #60 because it needs to be committed first before anything else can be even tested.

PHP's error handler signature changed in PHP8: it now passes 4 arguments instead of 5. (https://www.php.net/manual/en/function.set-error-handler.php) Drupal registers an error handler that has 5 required arguments, which means that any time any Notice/Deprecated message is emitted... a fatal error immediately follows because the error handler cannot be executed.

dsnopek commented 3 years ago

This looks great, thanks! Merging...