search

d6lts / drupal

Fork of Drupal core for Drupal 6 LTS support.
https://www.drupal.org
GNU General Public License v2.0
130 stars 45 forks source link

Fix URL bug introduced by Apache Update for CVE-2023-25690 #79

Open amorsent opened 1 year ago

amorsent commented 1 year ago

Backport of #284899: Drupal url problem with clean urls. https://www.drupal.org/project/drupal/issues/284899

Also fixes URL bugs introduced by Apache Update for CVE-2023-25690

Original commit: https://git.drupalcode.org/project/drupal/-/commit/1df3cfffefefc93ed2d29041d148938d08bb9d4e

Notes: Test changes from original commit is excluded because the equivalents don't exist in D6.

drupal_environment_initialize() does not exist in D6. I have added the code in _drupal_bootstrap(DRUPAL_BOOTSTRAP_CONFIGURATION)

The original commit only syncs $_GET['q']. I am also setting $_REQUEST['q'] because some contrib modules use that.

Some functions have different names in D6. drupal_encode_path() is drupal_urlencode() in D6 Drupal.encodePath() is Drupal.encodeURIComponent() in D6

The original commit changes autocomplete.js, but this change was later reversed for SA-CORE-2020-007 https://git.drupalcode.org/project/drupal/-/commit/cd3721550d988240ef6e682bd1cae2939c6e9e5a#5b6d51049ae7a66f45f48add03d6e3144d037ada

JPustkuchen commented 3 months ago

@amorsent have you been using this for a longer period of time? How mature would you say is this fix?