Refactor - Githubissues

d6o / GoTree

A Tree printer module written in GoLang

https://disiqueira.github.io/GoTree/

MIT License

191 stars 32 forks source link

Refactor #16

Closed icholy closed 5 years ago

icholy commented 5 years ago

Tree interface doesn't provide anything useful.
Node interface make it easier for external types to use Print.
Printer interface wasn't used for anything.
printer struct didn't serve any purpose.
strings.Builder is much more efficient.

davidovich commented 5 years ago

This is an API breaking change. The implementation may be more streamlined, but I am not sure that users would find such a change very useful, and would probably find that not breaking their code would outweigh a cosmetic refactoring.

d6o commented 5 years ago

I agree with @davidovich, and would prefer to keep the public methods the same.