d6o / GoTree

A Tree printer module written in GoLang
https://disiqueira.github.io/GoTree/
MIT License
191 stars 32 forks source link

Use pointers in GTStructure to allow mutation of the items before printing #6

Closed jaroslaw-bochniak closed 6 years ago

jaroslaw-bochniak commented 6 years ago

Hi,

I have just created a PR https://github.com/DiSiqueira/GoTree/pull/5 which changes items in GTStructure from value receiver to a pointer. This is an API breaking change so not sure if you are open for it.

This change basically has two benefits:

WDYT about it? All remarks are welcomed.

I am happy to update README.md as well with the usage example if you think that this PR brings any value.

d6o commented 6 years ago

Hey @jaroslaw-bochniak

Thank you for your contribution! I think the change makes a lot of sense, I created this package when I was learning GO so there is a lot to be improved on it. Lets follow with the PR, when merged I'll tag the new release with a breaking change.