search

d7415 / merlin

GNU General Public License v2.0
2 stars 10 forks source link

make config.py py3 compatible #9

Closed Um9i closed 6 years ago

Um9i commented 6 years ago

info about installing configparser from here.

d7415 commented 6 years ago

Looks good. I'm not sure about the requirements.txt. I'll have a read up on those.

I'm actually doing the same work (haven't pushed the "messy" stuff yet) on the whole repo. I'll also have to figure out whether it's better to require configparser or future. future probably helps with some other 2/3 problems.

I'm a little tempted to branch it all off and make a py3-only branch to save the hassle...

Um9i commented 6 years ago

using configparser seems to be the recommended way to go about it according to the latest release section here.

it references 2 issues 118 and 181 although im not sure they'd be much applicable to anyone.

the requirements.txt is not complete anyway (just the bot atm) and was only a convenience for myself to install packages with pip so feel free to ignore that.

d7415 commented 6 years ago

Thanks for doing my work for me :) That makes sense - unsurprisingly Debian's still using 0.15.2, hence my confusion.

I'll look at merging in some form this later tonight.

d7415 commented 6 years ago

Merged in the -py3 branches in c58a50cc3e2c6e594539a58a31d83c1c797d247e. I'm not going to put it into master just yet, so I'll leave this open for tracking.