Abstracted out BasicButton and BasicToolbox Forms/displays.

d8-contrib-modules / addthis

Port AddThis to D8

GNU General Public License v2.0

3 stars 13 forks source link

Abstracted out BasicButton and BasicToolbox Forms/displays. #22

Closed doylejd closed 9 years ago

doylejd commented 9 years ago

Abstracted out the BasicButton and BasicToolbox forms to allow for reuse in field/block
Abstracted out displays for BasicButton and BasicToolbox to allow for reuse in field/block
Updated Block settings form to allow for Type selection and conditional display of subfields
Updated Block/Fields Form and Display functions to call shared functions
Hooked up Services validation function for the BasicToolbox form

doylejd commented 9 years ago

Resolves issue https://github.com/d8-contrib-modules/addthis/issues/20

nerdstein commented 9 years ago

@doylejd - big things from my review:

module files should only contain hooks, all custom callbacks should be in controller classes
The 'AddThis' class itself looks like a potential controller.

Controllers should go into src/Controller

doylejd commented 9 years ago

@nerdstein Added comments and refactored code based on standards.

Investigating Controller classes and the ability to move the validate function. Additional refactoring may be needed. If so, I will open new issues for it.