Currently we are using a helper method in the AddThis.php class to provide the form elements for the AddThisBasicButton and AddThisBasicToolbox config options which are shared between formatter and block.
After talking to Kris yesterday, he suggested we take a look at a partial form or traits. He mentioned the form could be problematic because of how it gets pulled in and the fact we only need partial form elements that will be shared.
Keep in mind how we make this extendable. Do we want to provide other modules the ability to add renderElement types that can be picked up by our block or do we just provide what we have and if they want something new, they can create both elements. (And still use the addThis for global config/js integration. How much benefit does this give?)
Currently we are using a helper method in the AddThis.php class to provide the form elements for the AddThisBasicButton and AddThisBasicToolbox config options which are shared between formatter and block.
After talking to Kris yesterday, he suggested we take a look at a partial form or traits. He mentioned the form could be problematic because of how it gets pulled in and the fact we only need partial form elements that will be shared.