d8-contrib-modules / addthis

Port AddThis to D8
GNU General Public License v2.0
3 stars 13 forks source link

Clean add this element add this wrapper #40

Closed ChuChuNaKu closed 9 years ago

nerdstein commented 9 years ago

@ChuChuNaKu - which issue are you referencing? please provide with all PRs

nerdstein commented 9 years ago

Reviewed and really impressed with how much cleanup occured in this PR, great job. I'll review with more context when I get the issue

ChuChuNaKu commented 9 years ago

@nerdstein sorry about that. This is for issue number https://github.com/d8-contrib-modules/addthis/issues/16. I had LOTS of help!

ChuChuNaKu commented 9 years ago

ok, @nerdstein I got rid of the commented code. @doylejd I reworked the fields.

doylejd commented 9 years ago

@ChuChuNaKu Going to merge this so Jason can get his stuff working, but I am pretty sure the config arrays are wrong in the field formatters. Lets get a new PR open for that.