search

d8-contrib-modules / cloudflare

Cloudflare Module for Drupal
16 stars 14 forks source link

Do not depend on the Composer Manager module. #21

Closed wimleers closed 9 years ago

wimleers commented 9 years ago

See https://bojanz.wordpress.com/2015/09/18/d8-composer-definitive-intro/.

No module should depend on composer_manager.

wimleers commented 9 years ago

So the (better) alternative would be to use composer require d8-contrib-modules/cloudflarephpsdk.

aweingarten commented 9 years ago

I have reservations about this approach. I potentially see it being difficult to maintain on a long-term project. The general approach that we have been taking on the PS side is that pretty much everything inside docroot with the exception of sites is a build artifact. That way we can blow away the docroot. Run drush make, run composer manager to rebuild dependencies, and then symlink in sites or restore sites from vcs(there is some internal debate on symlink vs restore from vcs)

aweingarten commented 9 years ago

Strike what I said. I've taken your work and added a hook requirements see: https://github.com/d8-contrib-modules/cloudflare/pull/24