search

d8-contrib-modules / ga_login

DEPRECATED - MOVED TO DRUPAL.ORG -- https://www.drupal.org/project/ga_login
1 stars 1 forks source link

Module needs a composer.json to support composer workflow #6

Closed aweingarten closed 8 years ago

aweingarten commented 8 years ago

D8 is moving towards replacing drush make with composer. To support a composer based workflow this module should have a composer.json.

Given that this is an alpha the module is probably not going to be registered on packagist or drupal's packagist. In the interim Module should ship with instructions on how to add the module to a composer.json.

therealssj commented 8 years ago

@aweingarten The external libraries are handled by the TFA module which has the composer.json file. All this module does is provided the setup classes. Setup classes like the name handle the setting up of the validation method. Basically everyting under the security tab at user/id/security/tfa

nerdstein commented 8 years ago

I think this composer.json file is actually used for composer-based workflows in Drupal. Some Drupal 8 sites are completely managed by Composer

nerdstein commented 8 years ago

As such, it needs a composer.json file for the metadata of the module

therealssj commented 8 years ago

https://github.com/d8-contrib-modules/ga_login/pull/10