Implemented-flood-control

d8-contrib-modules / tfa

DEPRECATED - D8 TFA port now on drupal.org

https://www.drupal.org/project/tfa

5 stars 11 forks source link

Implemented-flood-control #26

Closed vg3095 closed 8 years ago

vg3095 commented 8 years ago

Implemented flood controls using Drupal flood service and utilized user_login_finalize for additional flood control stuff.

therealssj commented 8 years ago

https://github.com/d8-contrib-modules/tfa/pull/17 This pull request. We are not using TFAManager class anymore, I don't think we have any use for these changes here.

vg3095 commented 8 years ago

I read this issue #12 .That`s why I implemented it.

therealssj commented 8 years ago

I do not intend to say it is wrong. I am just pointing out the fact that we are not using TFAManager any more. Issue #12 states that flood control doesn't work. It does not say where the fix has to be done.

vg3095 commented 8 years ago

So, I think this should become part of Login plugin manager then

therealssj commented 8 years ago

Umm I am not sure. Would be good if we discuss this here https://github.com/d8-contrib-modules/tfa/issues/12 Drop your thoughts on this so others can also contribute :)