d8ahazard / sd_dreambooth_extension

Other
1.85k stars 283 forks source link

Pin diffusers due to deprecation #1469

Closed GrahamTheCoder closed 1 month ago

GrahamTheCoder commented 3 months ago

Fixes #1470

Describe your changes

Pin the version of diffusers to one that is compatible

Checklist before requesting a review

d8ahazard commented 3 months ago

I appreciate the workaround, but think it'd be ideal to update/add the missing deprecated methods, or change them to use the official HF versions, no?

GrahamTheCoder commented 3 months ago

Agreed that'd be ideal.

Since that hasn't happened prior to the breaking change despite warnings, I think merging a fix that keeps things working (as they used to) is a good idea.

Or more generally, for the sake of general stability, could apply pinning of dependencies that are in danger of breaking (E. G. Pin 0.* precisely, and pin others within major version)