search

d99kris / nchat

Terminal-based Telegram / WhatsApp client for Linux and macOS
MIT License
742 stars 48 forks source link

Forwarding a picture on whatsapp turns it into a document #280

Closed hseg closed 3 months ago

hseg commented 3 months ago

Description: When forwarding an image in a Whatsapp account, it appears as a document.

How to reproduce it: Send a JPG image over whatsapp. Select it and press <alt-r> to forward it to (even the same!) chat. Notice when it arrives that what was an image now appears as a document (indeed, its name is now changed from hash.jpg to hash-hash.jpg for some hashes hash)

Environment:

d99kris commented 3 months ago

Hi @hseg - thanks for reporting a bug! I can reproduce the issue here as well. Will look into this.

d99kris commented 3 months ago

Hi again - the issue should be fixed with above commit. Please let me know if it's not.

hseg commented 2 months ago

It didn't fix it -- just tested it with a build off ca01274, and I still can reproduce: I forwarded a JPG back to myself, and got it as a document

EDIT: For some reason, rebuilding nchat on that version does fix the bug. If this strikes again, I'll reopen the bug, but for now things look good. One thing that may have confused me is that I checked the version using my package manager -- it may be useful to have nchat --version report the commit it was built on for sanity-checking

d99kris commented 2 months ago

it may be useful to have nchat --version report the commit it was built on for sanity-checking

Thanks for the suggestion, I'll see if I can add this.