d99kris / nchat

Terminal-based Telegram / WhatsApp client for Linux and macOS
MIT License
619 stars 43 forks source link

External file manager support #67

Closed Bellavene closed 2 years ago

Bellavene commented 2 years ago

Would be awesome if we could use ranger, nnn or etc. to pick up a file for sending. So we can preview them or find the needed one faster.

d99kris commented 2 years ago

Yeah, it's not a bad idea. Will see if I can leverage the external file picker support I implemented for nmail.

Bellavene commented 2 years ago

Thank You. Waiting for this the most, and for support of other messengers too!

d99kris commented 2 years ago

Hi! I finally got a chance to take a look at this. It's been implemented in above commit and is configurable using the new file_picker_command config parameter. Check the README.md for details / example.

Bellavene commented 2 years ago

Thank you!

Bellavene commented 2 years ago

Something went wrong for me

~/Downloads/nchat/mkdir -p build && cd build && cmake .. && make -s
-- Using build type 'RelWithDebInfo' (default).
-- Ncurses cmake prefix '/opt/homebrew/opt/ncurses' (detected).
-- Dummy: OFF
-- Telegram: ON
-- WhatsApp: ON
CMake Error at /opt/homebrew/Cellar/cmake/3.23.2/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find SQLite3 (missing: SQLite3_INCLUDE_DIR SQLite3_LIBRARY)
Call Stack (most recent call first):
  /opt/homebrew/Cellar/cmake/3.23.2/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:594 (_FPHSA_FAILURE_MESSAGE)
  /opt/homebrew/Cellar/cmake/3.23.2/share/cmake/Modules/FindSQLite3.cmake:54 (find_package_handle_standard_args)
  lib/ncutil/CMakeLists.txt:18 (find_package)
d99kris commented 2 years ago

That's odd, there haven't been any recent changes related to sqlite dependencies that I can recall.

Could you perhaps try making sure sqlite is installed brew install sqlite (assuming you're using brew)?

Also, in case you've used an old clone/checkout that you've updated, perhaps try deleting the old build directory, and retry the build command again.

Bellavene commented 2 years ago

Thank you, my bad, reinstalled it, and it is working.

d99kris commented 2 years ago

Good to hear! No worries! 👍