dCache / dcache

dCache - a system for storing and retrieving huge amounts of data, distributed among a large number of heterogenous server nodes, under a single virtual filesystem tree with a variety of standard access methods
https://dcache.org
291 stars 136 forks source link

WebDAV browser interface missing some visual elements #6933

Closed onnozweers closed 1 year ago

onnozweers commented 1 year ago

Dear dCache devs,

I've noticed in dCache 8.2 and the master snapshot 9.0, that some visual elements are missing from the browser interface of the WebDAV doors.

I've tested several of our WebDAV doors; they all look similarly austere. It's the same in Firefox and Chrome. I've looked at the browser console in Chrome and it gives no error or other indication that might explain this.

I'll attach a screen print.

Cheers, Onno

Scherm­afbeelding 2022-12-23 om 11 32 11

And old screen shot:

image

alrossi commented 1 year ago

I can definitely confirm this. There seems to be some problem with either the css or js in our static deployment. This actually happened between 6.2 and 7.2. I can confirm this by doing the following.

  1. In the 8.2/master installation, do rm -rf /usr/share/dcache/webdav
  2. From the 6.2 branch, copy cp -r skel/share/webdav <host>/usr/share/dcache
  3. Clear the browser cache
  4. Refresh the browser page.

6.2 looks like your second image above. 7.2 already looks like the garbled one (the first).

Now we have to see what exactly changed.

alrossi commented 1 year ago

Evidently caused by an update of the boostrap and jquery libraries which was backported through 7.2

Investigating best solution.

elenamplanas commented 1 year ago

We've observed the same behavior, also running 8.2.

imatge

Don't hesitate to contact us for anything you need. Cheers!

alrossi commented 1 year ago

Apologies for this. We have discussed the problem, but since it is library dependent and there seem to be security issues in returning to an earlier version, we still don't have a clear path to resolution.

elenamplanas commented 1 year ago

Hi Al,

No problem, I've just added the comment because during the dcache meeting I've commented this, and Tigran recommended to open an issue.

Missatge de Albert Rossi @.***> del dia dc., 10 de maig 2023 a les 16:54:

Apologies for this. We have discussed the problem, but since it is library dependent and there seem to be security issues in returning to an earlier version, we still don't have a clear path to resolution.

— Reply to this email directly, view it on GitHub https://github.com/dCache/dcache/issues/6933#issuecomment-1542350704, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGJO2432SDGIVFW4WJYF5SDXFOT2TANCNFSM6AAAAAATHUIE74 . You are receiving this because you commented.Message ID: @.***>

-- Elena Planas PIC/Institut de Física d’Altes Energies (IFAE), The Barcelona Institute of Science and Technology, Campus UAB 08193 Bellaterra (Barcelona) +34-93 164 16 55

kofemann commented 1 year ago

🎉

image

kofemann commented 1 year ago

@onnozweers @elenamplanas could you please check that the fix in master fixes the observerd issue?

onnozweers commented 1 year ago

Hi Tigran,

Thanks! It looks beautiful! Love the new tape icon.

afbeelding

One minor remaining issue though: the identity icon in the upper right corner does not open when you click it. I tested with Chrome and Firefox on MacOS.

Cheers, Onno

kofemann commented 1 year ago

Thanks, @onnozweers. I will keep fixing.

kofemann commented 1 year ago

image

onnozweers commented 1 year ago

It works, but... The info falls off the page, unless I make the window very large.

afbeelding

When I change this CSS value:

dropdown.scss:66

.dropdown-menu[data-bs-popper] {
    ...
    left: 0;
}

Into:

.dropdown-menu[data-bs-popper] {
    ...
    right: 0;
}

The box becomes right-aligned, and it can always be seen.

afbeelding

I can't seem to find this piece of CSS in the code though. I'm sure you know where it is.

kofemann commented 1 year ago

image