search

dCache / nfs4j

Pure Java NFSv3 and NFSv4.2 implementation
Other
240 stars 76 forks source link

fix issue with Stat.toString() when size=0 (log returns -inf) #11

Closed radai-rosenblatt closed 10 years ago

radai-rosenblatt commented 10 years ago

Math.log(0) = -infinity

dcache-ci commented 10 years ago

Can one of the admins verify this patch?

kofemann commented 10 years ago

this is ok to test

radai-rosenblatt commented 10 years ago

now returns "0" instead of "" (not sure if new comments on outdated diffs are visible or not)

radai-rosenblatt commented 10 years ago

having issues with mockito re-using previously-defined mocked behaviours (defined in other test methods)

kofemann commented 10 years ago

thanks!

kofemann commented 10 years ago

Ok, I see why test is broken. NFS server has a static cache for directory listings. As cache key is build with generation now, we hit old data. I will remove static as it makes no sense there. For v4 I will need to find a better solution.

radai-rosenblatt commented 10 years ago

thank you very much :+1: