allocate and use a single verifier instance instead of creating a new on...

dCache / nfs4j

Pure Java NFSv3 and NFSv4.2 implementation

Other

240 stars 76 forks source link

allocate and use a single verifier instance instead of creating a new on... #28

Closed radai-rosenblatt closed 10 years ago

radai-rosenblatt commented 10 years ago

...e for every write/commit

nfs3 rfc says the verifier is fixed for the duration of a server's lifetime and should change on server restarts (nfs4 goes further and says it must change).

current code allocates a new, blank, verifier on each write/commit. since it should never change its better to allocate it once and reuse the same instance.

dcache-ci commented 10 years ago

Can one of the admins verify this patch?

kofemann commented 10 years ago

ok to test.

radai-rosenblatt commented 10 years ago

done - switched to Bytes.putLong()

kofemann commented 10 years ago

ok to test.

kofemann commented 10 years ago

Thanks