search

dCache / nfs4j

Pure Java NFSv3 and NFSv4.2 implementation
Other
240 stars 76 forks source link

nfs4: set response committed value properly in op COMMIT based on VFS WriteResult return value #67

Closed Toilal closed 5 years ago

Toilal commented 5 years ago

I'm trying to implement a VirtualFileSystem with UNSTABLE writing support, but commit is never called by client because of this hardcoded value.

dcache-ci commented 5 years ago

Can one of the admins verify this patch?

kofemann commented 5 years ago

ok to test

On Tue, Dec 11, 2018, 16:40 dcache-ci <notifications@github.com wrote:

Can one of the admins verify this patch?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/dCache/nfs4j/pull/67#issuecomment-446247510, or mute the thread https://github.com/notifications/unsubscribe-auth/AAjJ3fmDYdwL6qtsirzbD5fHfC6LSwCuks5u39HVgaJpZM4ZNqrn .

kofemann commented 5 years ago

@Toilal please update the patch to include Signed-off-by

(commit -s - - ammend)

On Tue, Dec 11, 2018, 21:42 Tiramisu Mokka <kofemann@gmail.com wrote:

ok to test

On Tue, Dec 11, 2018, 16:40 dcache-ci <notifications@github.com wrote:

Can one of the admins verify this patch?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/dCache/nfs4j/pull/67#issuecomment-446247510, or mute the thread https://github.com/notifications/unsubscribe-auth/AAjJ3fmDYdwL6qtsirzbD5fHfC6LSwCuks5u39HVgaJpZM4ZNqrn .

Toilal commented 5 years ago

Signed, sorry 👍

Toilal commented 5 years ago

Would you consider publishing this library on maven central ?

kofemann commented 5 years ago

Thanks for PR. Yes, maven central makes sense as other projects use it.