search

dOpensource / dsiprouter

UI Interface for implementing Kamailio to provide PBX Hosting and SIP Trunking Services
https://dsiprouter.org
Apache License 2.0
196 stars 104 forks source link

Hostnames entered into Carrier Groups are not converted to IP Addresses #325

Open mackhendricks opened 3 years ago

mackhendricks commented 3 years ago

This causes dSIPRouter to loop the call in from the carrier and then back out to the carrier

Reproducible Use Case

1) login to dSIPRouter 2) Click Carrier Groups 3) Add a Carrier Group 4) Click the new Carrier Group 5) Click the Endpoint Tab 6) Enter an Friendly Name 7) Enter sip.telnyx.com or some other carrier hostname 8) Click Update and Reload

mackhendricks commented 3 years ago

The main issue is that inbound traffic is denied if the IP address that represents the hostname is not in the address table. Note, we need to figure out how to handle hostnames that have multiple ip's attached to them (aka DNS SVR records)

Please use shared.safeUriToHost to ensure the hostname is clean and then call shared.hostToIP(host) to convert the hostname to IP address

mackhendricks commented 3 years ago

Hey Richard, I'm re-assigning this for 0.642s. I see a commit for updating the Endpoint Groups, but I don't see a commit for Carrier Groups. Please commit and make sure to tag the commit with the this issue number.

devopsec commented 1 year ago

This issue was never merged in.
Ref: #391