[BUG] 500 Server Error from Comma in Inbound Route Name Field

[bowyern]

Describe the bug If you add a comma to the Friendly Name field of an Inbound route, either via Add or Import, Inbound Routes will return a 500 server error after that.

Manually removing the comma from the description name: field in the database restores UI functionality.

To Reproduce Go to Inbound Routes. Click Add. Put "Test 1, 2, 3" in the Friendly Name field. Put any 10 digits into the DID field. Select an Endpoint group. Click Add. See 500 server error.

Expected behavior The number should be added, or it should error on incorrect user input.

Server Info:

• OS: Linux voip-1 5.10.0-25-cloud-amd64 #1 SMP Debian 5.10.191-1 (2023-08-16) x86_64 GNU/Linux
• Distro: PRETTY_NAME="Debian GNU/Linux 11 (bullseye)" NAME="Debian GNU/Linux" VERSION_ID="11" VERSION="11 (bullseye)" VERSION_CODENAME=bullseye ID=debian HOME_URL="https://www.debian.org/" SUPPORT_URL="https://www.debian.org/support" BUG_REPORT_URL="https://bugs.debian.org/"
• dSIPRouter Version: 0.70 If not on a release version include the branch name and last commit id
• Kamailio Version: version: kamailio 5.5.6 (x86_64/linux) flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 10.2.1
• RTPengine Version: Version: 9.3.1.4+0~mr9.3.1.4 git-HEAD-934c4f0
• Python Package Versions: if applicable, include output from /opt/dsiprouter/venv/bin/python -m pip freeze

[bowyern]

I think this is related:

[2023-12-27 15:47:19] [1023223->139957682251584] [ERROR]: ((( EXCEPTION ))) [CLASS]: <class 'ValueError'> [VALUE]: dictionary update sequence element #1 has length 1; 2 is required ((( BACKTRACE )))

[SOURCE]: return render_template('inboundmapping.html', rows=res, gwgroups=gwgroups, epgroups=epgroups, imported_dids=dids)

[devopsec]

This issue is due to the description field in the DB being used as a comma separated list of sub-fields.
The fix would be to change the DB structure to JSON type or creating a related table for the data.
I would prefer just using the JSON type here as its simpler and is supported in the htables now: https://www.kamailio.org/docs/modules/devel/modules/htable.html#htable.p.htable