search

dOrgTech / DAOcreator

dApp for creating and interacting with DAOs
https://dorg.tech
MIT License
35 stars 18 forks source link

use migration 0.1.1-rc.13-v1 for the experimental daocreator. #494

Closed orenyodfat closed 4 years ago

orenyodfat commented 4 years ago

https://github.com/daostack/migration/releases/tag/0.1.1-rc.13-v1 this will reduce the dao creation transactions to 2 in most of the cases. (no need to set gp parameters)

dOrgJelli commented 4 years ago

Okay will do @orenyodfat. How is this achieved? If there are new VM parameters being used, don't you still have to setParameters on GenesisProtocol if they don't exist on-chain?

orenyodfat commented 4 years ago

it is set at the schemes initilise functions.. for example see https://github.com/daostack/arc/blob/arc-factory/contracts/schemes/ContributionReward.sol#L102

dOrgJelli commented 4 years ago

@orenyodfat I can do this once subgraph's experimental version is updated to use this migration version. If I were to do this now, private network deployments would fail because migration.json addresses would not be present.

orenyodfat commented 4 years ago

subgraph is now updated to support it https://github.com/daostack/subgraph/releases/tag/ganache-0.1.1-rc.13-v1-0.1.1-rc.7-v4

orenyodfat commented 4 years ago

@dOrgJelli does this already been address ?