da-rth / yasb

A highly configurable cross-platform (Windows) status bar written in Python.
MIT License
1.43k stars 80 forks source link

Added WIFI widget & fixed weather #106

Closed wiki-Bird closed 1 year ago

wiki-Bird commented 1 year ago

Pull Request - #105 & #103

Description

I updated the config.yaml "last updated" information to reflect my updates.

Wifi Widget:

I added a new core "wifi' widget to widgets and validation. The widget uses os to get the user's signal strength, then displays said strength in the status bar using nerdfont icons (see image for icons) strength icons used On left click, the widget also displays the network name. It should be trivial to configure this to display other info, such as current upload/download rate. On right click, the widget opens Windows' network settings.

Weather Widget:

I implemented @zombie-bear's fix, using wttr.in instead of openweathermap.org. I, like zombie-bear, could not get openweathermap to function (possible due to API changes?), but after changing the API request to wttr.in had it working in seconds. I updated the default weather JSON paths to match the old content (temp in C, current condition), as well as the commented explanation in config.yaml.

Related Issues

Testing

OS: Windows 10 Pro Komorebi: Yes Python: 3.11.4 Terminal: Windows PowerShell in Windows Terminal

All of these performed as expected.

da-rth commented 1 year ago

I haven't really been maintaining the python version of yasb as of recent, but this contribution looks great. The changes look pretty good so I'm happy to merge this in.

Thank you for your contribution