prevent cooked mode from creating messages with empty values

da4089 / simplefix

Simple FIX protocol implementation for Python

MIT License

229 stars 63 forks source link

prevent cooked mode from creating messages with empty values #10

Closed gjvc closed 6 years ago

gjvc commented 6 years ago

...but still allow the use of raw mode for expert use.

coveralls commented 6 years ago

Coverage increased (+0.004%) to 95.23% when pulling c1daf34afc8ffa411f2f77c4efaa94144b92bde0 on gjvc:patch-1 into ee682ab35cac6e8e7fe989fe8357f7844b738543 on da4089:master.

da4089 commented 6 years ago

@gjvc, how were you able to get a None value into the pairs list? In looking at append_pair(), it converts everything using fix_val(), which will change None to a byte-string b"None" in both 2.7 and 3.6, I think?