search

da667 / Autosnort

Repo for autosnort scripts.
MIT License
157 stars 84 forks source link

Multiple sleep statements #1

Closed flowchartsman closed 12 years ago

flowchartsman commented 12 years ago

All of those "sleep 2" lines seem unnecessary to me. I suppose you could make a case for allowing the user time to abort at any step or for giving them time to read the output, but I don't think either of these are valid concerns. If I'm building something, I don't really care very much about success messages and, if I do, I'll pipe it through less. If it bails on error, then the terminal will be left sitting on the relevant data anyway.

da667 commented 12 years ago

Will agree to this. I do want to leave the initial sleep statement warning the user if the script is ran on a non-ubuntu system, and the sleep statement reminding the user what the snort mysql user's password is. A reasonable compromise?

flowchartsman commented 12 years ago

Don't sleep for informational purposes. Use a read to prompt for the first, and echo the mysql password at the very end.

flowchartsman commented 12 years ago

Pull request submitted for it.