search

daKmoR / rocket

Move to https://github.com/modernweb-dev/rocket/
MIT License
13 stars 5 forks source link

chore: add .nvmrc #147

Closed manolakis closed 3 years ago

manolakis commented 3 years ago

What I did

  1. I added the .nvmrc file to indicate that node v14 is required in this project
changeset-bot[bot] commented 3 years ago

⚠️ No Changeset found

Latest commit: 6fcf949ce6dad5fb3a2e852d8306b34e6470adb2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

bennypowers commented 3 years ago

can this be a range of "at least v14"? I'm using v15 features in my site

manolakis commented 3 years ago

I'm not sure if I'm understanding you. This .nvmrc should point to the minimal node version required to build this repo. Your site I guess is in another repo and would require the npm packages of this one, but this .nvmrc is not going to affect to your repo. You can have another .nvmrc pointing to node v15.

bennypowers commented 3 years ago

@manolakis you're right, my mistake

daKmoR commented 3 years ago

not sure who will use that file... 🤔

but we can certainly add it - thx 🤗

manolakis commented 3 years ago

I use it! 😅

daKmoR commented 3 years ago

I use it! 😅

how? do you check it manually and then run nvm? or do you run nvm whenever you go into a directory? 🤔

manolakis commented 3 years ago

nvm is executed automatically when I enter in a dir o subdir with the file.

https://github.com/nvm-sh/nvm#zsh